Address comments

CoreumFoundation · Dec 8, 2023 · d0ed1cd · d0ed1cd
1 parent ebba217
commit d0ed1cd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/integration-tests/xrpl/scanner_test.go b/integration-tests/xrpl/scanner_test.go
@@ -174,8 +174,7 @@ func validateTxsHashesInChannel(ctx context.Context, writtenTxHashes map[string]
 		case tx := <-txsCh:
 			// validate that we have all sent hashed and no duplicated
 			hash := tx.GetHash().String()
-			_, found := expectedHashes[hash]
-			if !found {
+			if _, found := expectedHashes[hash]; !found {
 				return errors.Errorf("not found expected tx hash:%s", hash)
 			}
 

diff --git a/relayer/processes/xrpl_tx_observer.go b/relayer/processes/xrpl_tx_observer.go
@@ -68,7 +68,7 @@ func (o *XRPLTxObserver) Start(ctx context.Context) error {
 			defer close(txCh)
 			return o.txScanner.ScanTxs(ctx, txCh)
 		})
-		spawn("tx-processor", parallel.Continue, func(ctx context.Context) error {
+		spawn("tx-processor", parallel.Fail, func(ctx context.Context) error {
 			for tx := range txCh {
 				if err := o.processTx(ctx, tx); err != nil {
 					if errors.Is(err, context.Canceled) {
@@ -78,7 +78,7 @@ func (o *XRPLTxObserver) Start(ctx context.Context) error {
 					}
 				}
 			}
-			return nil
+			return errors.WithStack(ctx.Err())
 		})
 
 		return nil

diff --git a/relayer/xrpl/scanner.go b/relayer/xrpl/scanner.go
@@ -168,8 +168,7 @@ func (s *AccountScanner) scanTransactions(ctx context.Context, minLedger int64,
 				select {
 				case <-ctx.Done():
 					return lastLedger
-				default:
-					ch <- *tx
+				case ch <- *tx:
 				}
 			}
 		}