Fix comments and improve tests

CoreumFoundation · Nov 20, 2023 · e720402 · e720402
1 parent 890001e
commit e720402
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/integration-tests/coreum/contract_client_test.go b/integration-tests/coreum/contract_client_test.go
@@ -710,7 +710,6 @@ func TestSendFromXRPLToCoreumXRPLOriginatedTokenWithDifferentSendingPrecision(t
 				_, err = contractClient.SendXRPLToCoreumTransferEvidence(ctx, relayer.CoreumAddress, xrplToCoreumTransferEvidence)
 				if tt.wantIsAmountSentIsZeroAfterTruncationError {
 					require.True(t, coreum.IsAmountSentIsZeroAfterTruncationError(err), err)
-					return
 				}
 				if tt.wantIsMaximumBridgedAmountReachedError {
 					require.True(t, coreum.IsMaximumBridgedAmountReachedError(err), err)
@@ -1274,7 +1273,6 @@ func TestSendFromCoreumToXRPLXRPLOriginatedTokenWithDifferentSendingPrecision(t
 			_, err = contractClient.SendToXRPL(ctx, coreumSenderAddress, xrplRecipient.String(), sdk.NewCoin(registeredXRPLToken.CoreumDenom, tt.sendingAmount))
 			if tt.wantIsAmountSentIsZeroAfterTruncationError {
 				require.True(t, coreum.IsAmountSentIsZeroAfterTruncationError(err), err)
-				return
 			}
 			require.NoError(t, err)
 
@@ -1286,7 +1284,6 @@ func TestSendFromCoreumToXRPLXRPLOriginatedTokenWithDifferentSendingPrecision(t
 				if operationType != nil && operationType.Issuer == issuer && operationType.Currency == currency {
 					found = true
 					require.Equal(t, tt.wantReceivedAmount.String(), operationType.Amount.String())
-					break
 				}
 			}
 			require.True(t, found)

diff --git a/integration-tests/xrpl.go b/integration-tests/xrpl.go
@@ -252,7 +252,7 @@ func (c XRPLChain) SubmitTx(ctx context.Context, t *testing.T, tx rippledata.Tra
 	})
 }
 
-// GetAccountBalance returns account balance for the provides issuer and currency.
+// GetAccountBalance returns account balance for the provided issuer and currency.
 func (c XRPLChain) GetAccountBalance(ctx context.Context, t *testing.T, account, issuer rippledata.Account, currency rippledata.Currency) rippledata.Amount {
 	return c.GetAccountBalances(ctx, t, account)[fmt.Sprintf("%s/%s", currency.String(), issuer.String())]
 }

diff --git a/relayer/processes/xrpl_tx_submitter.go b/relayer/processes/xrpl_tx_submitter.go
@@ -412,7 +412,7 @@ func (s *XRPLTxSubmitter) buildXRPLTxFromOperation(operation coreum.Operation) (
 	case isCoreumToXRPLTransfer(operation):
 		return BuildCoreumToXRPLTransferPaymentTxForMultiSigning(s.cfg.BridgeAccount, operation)
 	default:
-		return nil, errors.Errorf("failed to process operation, unable to determin operation type, operation:%+v", operation)
+		return nil, errors.Errorf("failed to process operation, unable to determine operation type, operation:%+v", operation)
 	}
 }