Skip to content

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Sep 15, 2023

No description provided.

… (#28103)

* cmd/geth, internal/flags, go.mod: colorize cli help, support env vars

* internal/flags: use stdout, not stderr for terminal detection
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #1720 (e6da247) into master (e4bda87) will increase coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 56.78%.

❗ Current head e6da247 differs from pull request most recent head 38a50c8. Consider uploading reports for the commit 38a50c8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1720      +/-   ##
==========================================
+ Coverage   52.75%   52.76%   +0.01%     
==========================================
  Files         483      485       +2     
  Lines       60657    60394     -263     
==========================================
- Hits        32000    31868     -132     
+ Misses      26218    26079     -139     
- Partials     2439     2447       +8     
Files Changed Coverage Δ
cmd/cortex/main.go 21.73% <ø> (ø)
consensus/cuckoo/cuckoo.go 35.78% <0.00%> (ø)
internal/flags/flags.go 9.00% <0.00%> (ø)
internal/flags/helpers.go 1.53% <0.00%> (-0.43%) ⬇️
metrics/graphite.go 0.00% <0.00%> (ø)
metrics/inactive.go 0.00% <0.00%> (ø)
metrics/internal/sampledata.go 0.00% <0.00%> (ø)
metrics/log.go 0.00% <0.00%> (ø)
metrics/metrics.go 26.85% <0.00%> (-1.04%) ⬇️
metrics/resetting_sample.go 0.00% <0.00%> (ø)
... and 18 more

... and 14 files with indirect coverage changes

@ucwong ucwong merged commit 016dcb5 into master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants