Skip to content

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Dec 20, 2023

No description provided.

…(#28525)

This is the fix to issue #27483. A new hiddenBytes() is introduced to calculate the byte size of hidden items in the freezer table. When reporting the size of the freezer table, size of the hidden items will be subtracted from the total size.

---------

Co-authored-by: Yifan <Yifan Wang>
Co-authored-by: Gary Rong <garyrong0905@gmail.com>
@ucwong ucwong marked this pull request as ready for review December 20, 2023 10:03
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (f8d7acb) 52.79% compared to head (858c1e3) 52.82%.
Report is 429 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1862      +/-   ##
==========================================
+ Coverage   52.79%   52.82%   +0.03%     
==========================================
  Files         491      491              
  Lines       60506    60517      +11     
==========================================
+ Hits        31942    31969      +27     
+ Misses      26121    26098      -23     
- Partials     2443     2450       +7     
Files Coverage Δ
core/rawdb/freezer_table.go 73.80% <60.00%> (-0.22%) ⬇️

... and 12 files with indirect coverage changes

@ucwong ucwong merged commit 461d238 into master Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants