Skip to content

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Mar 16, 2024

This change makes use of the following underlying changes to the kzg-libraries in order to avoid passing large things on the stack:

This change makes use of the following underlying changes to the kzg-libraries in order to avoid passing large things on the stack:

- c-kzg: ethereum/c-kzg-4844#393 and
- go-kzg: https://github.com/crate-crypto/go-kzg-4844/pull/63
@ucwong ucwong marked this pull request as draft March 16, 2024 09:03
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 47.26%. Comparing base (bd36b7e) to head (e437ef3).
Report is 20 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1938   +/-   ##
=======================================
  Coverage   47.26%   47.26%           
=======================================
  Files         568      568           
  Lines       68846    68846           
=======================================
+ Hits        32538    32542    +4     
+ Misses      33787    33786    -1     
+ Partials     2521     2518    -3     
Files Coverage Δ
crypto/kzg4844/kzg4844.go 19.60% <100.00%> (ø)
crypto/kzg4844/kzg4844_gokzg.go 64.70% <100.00%> (ø)
crypto/kzg4844/kzg4844_ckzg_nocgo.go 0.00% <0.00%> (ø)

... and 15 files with indirect coverage changes

@ucwong ucwong marked this pull request as ready for review March 16, 2024 12:55
@ucwong ucwong merged commit b3c7a4c into master Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants