This repository has been archived by the owner on Jul 2, 2019. It is now read-only.
Iss2 cli #42
Merged
Iss2 cli #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updating tests * restructuring repo * cleanup finished * adding graph functionality * fixing test imports * adding sphinx documentation * fixing requirements * fixing travis config for tests * adding rtfd configs * fixing env file * removing default channel * removing channels from rtfd env yml * adding fiona, removing gdal * removing nbsphinx * fixing api doc structure * first pass - unit tests for raster_image.image * implementing unit tests for image.py * implementing utils.core tests * Iss18 geoutils tests (#26) * completed test for geometries_internal_intersection * implementing split_multi_geometry tests * completed geoutils tests * fixing imports in test * removing python 2.7 support * [WIP] Iss22 poly tests (#27) Iss22 poly tests * Iss21 mask tests (#29) * completed test for geometries_internal_intersection * implementing split_multi_geometry tests * completed geoutils tests * fixing imports in test * removing python 2.7 support * adding polygon tests * fixing TestConvertPolyCoords class - remove init * adding affine xform gdf test * finished with tests for cw_geodata.vector_label.polygon * adding _check_wkt_load * finished implementing tests for cw_geodata.vector_label.mask * fixing overlap test with improved geometries_internal_intersection * Iss20 graph tests (#30) * completed test for geometries_internal_intersection * implementing split_multi_geometry tests * completed geoutils tests * fixing imports in test * removing python 2.7 support * adding polygon tests * fixing TestConvertPolyCoords class - remove init * adding affine xform gdf test * finished with tests for cw_geodata.vector_label.polygon * adding _check_wkt_load * finished implementing tests for cw_geodata.vector_label.mask * fixing overlap test with improved geometries_internal_intersection * adding test for graph creation * bugfix to valid_road_types formatting * version bump * completed OOP restructure, removed osmnx (#33) * enabled multiprocessing * thanks pandas * version bump and removing osmnx dependency
|
Hello @nrweir! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
Ignoring the one PEP8 issue since it's not an error in the API, and fixing it would've actually made the code less readable. |
This was referenced Apr 10, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding CLI functionality as well as CLI unit tests (#2 and #40). Additionally adds the ability to convert from masks to vector images and tests for graph export (#39).