Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved ACR registry to a platform key #30

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Conversation

o-reo
Copy link
Contributor

@o-reo o-reo commented Oct 17, 2022

To test the new commands proceed as follow:

  • install the new dependencies using pip install -r requirements.txt
  • Add or edit the following lines in config/platforms/platform.yml
# ACR registry name
acr_registry_name: "phoenixml.azurecr.io"
api_url: "https://dev.api.cosmotech.com"
api_scope: "http://dev.api.cosmotech.com/.default"
  • Add or edit the following lines in config/deployments/deploy.yml
# ACR image reference (repository:tag)
acr_image_reference: "hello-world:latest"

ACR GET ALL

babylon azure acr get-all

Should list all images in the given registry
Can be checked against az acr repository list --name my_registry --output table

ACR PUSH

Please first pull hello-world locally with docker pull hello-world

babylon azure acr push

Should add a new entry to az acr repository list --name my_registry with the latest tag

Clean

Clean the hello world image with

az acr repository delete -n phoenixml --repository hello-world

ACR PULL

Please choose an existing image with az acr repository list --name phoenixml --output table

babylon azure acr pull this_image_does_not_exist

Should provide a clean error log

babylon azure acr pull existing_image -t existing_tag

Should add a new entry to docker image ls

babylon azure acr pull existing_image

Should a new entry to docker image ls with the latest tag

Clean

Clean docker images using

docker image ls
docker image rm image_id

Copy link
Member

@neomatamune neomatamune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@o-reo o-reo merged commit 5b2f343 into main Oct 17, 2022
@o-reo o-reo deleted the eru/docker_push_pull_rework branch October 17, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants