This repository was archived by the owner on Sep 25, 2019. It is now read-only.
Implement the evaluator skeleton #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Use nested module/class definitions instead of compact style.
This includes a stub client object to prevent tests from changing the global client configuration. This prevents tests from randomly failing.
|
@allenwq do you want to review this? :) |
|
Sure, this will give me a better understand of the whole framework. |
|
@lowjoel You are implementing a gem for the evaluator, how does this gem suppose to work ? Will this it be installed in a rails app and handles requests ? |
|
nope. just install the gem on the evaluator machine, set it up as a system service |
|
Then you will also add logic to let it be able to handle concurrent requests ? |
|
probably not. |
|
maybe in future? we only have one CPU on most of the small VMs |
|
Okay, thanks ! |
allenwq
pushed a commit
that referenced
this pull request
Dec 16, 2015
Implement the evaluator skeleton
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.