Implement an integration test for evaluating a package. #14
Conversation
There was a problem hiding this comment.
Use snake_case for source file names.
This fully exercises every part of the evaluator, except the CLI.
lowjoel
force-pushed
the
integration-test
branch
from
dc1d508 to
b6032d0
Compare
There was a problem hiding this comment.
I'm wondering why you are using StringIO for the package ?
There was a problem hiding this comment.
Because I want a consistent API for Packages. Eventually I want to pass a stream in, see #10. Since I get an entire buffer at once now, the best is to use a StringIO.
Then there's the reason of why I need the custom StringIO -- that's because StringIO does not inherit from IO, rightly or wrongly.
There was a problem hiding this comment.
Yah, I noticed that custom StringIO, but not sure RubyZip completely works with that. that' why I'm asking.
There was a problem hiding this comment.
It doesn't, it's a hack...
And Rubyzip is so nasty I'm not sure I want to PR to fix it there... it's probably because it's a port from Java.
Implement an integration test for evaluating a package.
3 participants
This fully exercises every part of the evaluator, except the CLI.