This repository was archived by the owner on Sep 25, 2019. It is now read-only.
Implement saving #18
Merged
Implement saving #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lowjoel
commented
Jan 22, 2016
lowjoel
commented
- Parse Docker logs for the attach protocol
- Implement saving to the server
lib/coursemology/evaluator/utils.rb
Outdated
There was a problem hiding this comment.
Assignment in condition - you probably meant to use ==.
lowjoel
force-pushed
the
implement-saving
branch
2 times, most recently
from
70e1d6d to
d7de507
Compare
|
@allenwq sorry, I was half asleep when fixing rubocop warnings... |
lowjoel
force-pushed
the
implement-saving
branch
from
d7de507 to
43e04d7
Compare
|
@allenwq any other comments? |
This is for compatibility with the Rails' controllers' strong parameters.
…e to the server.
lowjoel
force-pushed
the
implement-saving
branch
from
43e04d7 to
077cd1c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.