Skip to content
This repository was archived by the owner on Sep 25, 2019. It is now read-only.

Conversation

lowjoel
Copy link
Member

@lowjoel lowjoel commented Jan 24, 2016

No description provided.

@lowjoel
Copy link
Member Author

lowjoel commented Jan 24, 2016

@allenwq I've no clue why Travis failing, you can run this on your local machine?

@allenwq
Copy link
Member

allenwq commented Jan 24, 2016

OK, it only fails on this commit or it also fails on the merged commits ?

@lowjoel
Copy link
Member Author

lowjoel commented Jan 24, 2016

I think Travis has some configuration problem, it runs fine on my computer.

@allenwq
Copy link
Member

allenwq commented Jan 24, 2016

Yeah, I set up the environment and tests passed on my local.

@lowjoel
Copy link
Member Author

lowjoel commented Jan 24, 2016

So, do we merge this?

@allenwq
Copy link
Member

allenwq commented Jan 24, 2016

Sure

allenwq pushed a commit that referenced this pull request Jan 24, 2016
Implement collecting the exit code from the container.
@allenwq allenwq merged commit 7fb6e84 into Coursemology:master Jan 24, 2016
@lowjoel lowjoel deleted the collect-container-exit-code branch January 28, 2016 08:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants