This repository was archived by the owner on Sep 25, 2019. It is now read-only.
Implement the Client loop #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowjoel
force-pushed
the
client-loop
branch
2 times, most recently
from
c993429 to
b8308d8
Compare
This mode will run the evaluator and only attempt to evaluate zero or one evaluation. This is needed for testing purposes.
There was a problem hiding this comment.
@lowjoel If this is a gem, Gemfile.lock should not be checked into the repo ?
There was a problem hiding this comment.
Yes, but this gem is a gem that is to be used as a client program... so nothing should depend on evaluator-slave.
Gemfile.lock should not be in the repo if it's a library and other things include it, because then the dependencies might not resolve.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will keep running the client and wait for new pending evaluations from the server.
New command line argument
--one-shotto only poll the server once, then immediately quit.