-
Notifications
You must be signed in to change notification settings - Fork 70
Generate page extraneous objects #1596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate page extraneous objects #1596
Conversation
…and improve readability
… into generate-page-extraneous-objects
Pull Request Test Coverage Report for Build dcca69fe-0286-465d-9841-42c195111577Details
💛 - Coveralls |
Hi David, I've written up tests to ensure that my bug fix is working as intended; however, these tests only pass locally. In the CI run, they are failing with the below error message:
I believe this issue stems from the fact that graphviz is not installed in the CI container, but I'm a bit apprehensive on just adding an install command to the CI config for it - was hoping for a second opinion. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akarki2005 nice work! I just left one minor comment, but overall the test approach is good. It's okay (and in fact, a good idea) to modify the CI configuration to install the system package for graphviz there.
Proposed Changes
This change fixes an issue which was causing extraneous nodes to appear in graphs on the generate page.
Before
Extraneous ellipses would appear on top of directed edges when hovering over a course to reveal its prerequisites.
After
These extraneous ellipses have been removed.
Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request: