NBT tag too big

[MrRedRhino]

Describe the Bug

I'm sure that you are aware of this bug.
If you pick up a miner that has too many items in it, the nbt tag of it will be too big and you can't join the server anymore.

Reproduction Steps

1. Make giant minecraft contraption
2. But a ton of items in it
3. Pick it up
4. Get kicked
5. Optional: Get kicked again every time you join the server
6. Optional: Profit

Expected Result

If the NBT size is too large, forbid picking it up

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

macOS Big Sur 11.5.2

Mod Version

0.4.0f

Minecraft Version

1.18.2

Forge Version

39.1.2

Other Mods

No response

Additional Context

Big miner.

[MrRedRhino]

There seems to be a check to fix this, right?
Very weird that it doesn't work

[PiTheGuy]

Someone else also recently reported this. What I'm noticing is in both cases, the size of the NBT tag was only over the max by a few bytes. This makes me think that something isn't accounted for when determining the size used in the check. I don't know what that could be and I haven't really done any proper testing so it could be something completely different, but I thought I would throw that out there for anyone who may want to debug this.

[MrRedRhino]

I think it doesn't take the other items in the players inventory into account

[MrRedRhino]

There was a mod for Minecraft 1.16.5 that increased the maximum packet size to 2 GB but it hasn't been ported to 1.18 at the time of writing this

[HyDefier]

I had this problem too. Is there a way to check the player's current inventory size?

1.19.2+ Packet mods (Mutually Exclusive):
https://www.curseforge.com/minecraft/mc-mods/packet-size-doubler-forge
https://www.curseforge.com/minecraft/mc-mods/connectivity

[TonimatasDEV]

This problem is fixed using: https://www.curseforge.com/minecraft/mc-mods/packet-fixer