Refactor/upgrade create react app #21
Conversation
source/emoji.js
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| module.exports = function(emoji, fallback = '') { | |||
| return process.stdout.isTTY && process.platform === 'darwin' | |||
| ? `${emoji} ` | |||
| ? emoji | |||
There was a problem hiding this comment.
nested ternary?
not fan, do we have a policy on that?
There was a problem hiding this comment.
Nope, but I removed it for you. Better?
|
As far as I know, there’s no way of passing input when you use npm scripts within code. The vs code tasks file lets you run a script on the file that is currently open in the editor via some environment variables. If you can find a way to do the same without tasks.json we should switch to that. Until then I want it to stay |
|
|
|
Sure. We could also fait for Creuna-Oslo/react-scripts#13 |
|
@pellebjerkestrand Now updated to v2 of react-scripts as well. I also moved the logging of help when command is missing to the top of |
|
Tested on windows in Powershell. Everything but |
# Conflicts: # package.json # yarn.lock
# Conflicts: # package.json
…ent message naming
|
Both I and @serling have tested |
Upgrades to
@creuna/create-react-app@2.0.0create-react-app.vscode/tasks.jsonFixes #20