Feat/assign operator parsing #98

ArchitGupta07 · 2024-08-25T10:36:57Z

PR Description

Updated parser.py to handle Assignment AND, Assignment OR, Assignment XOR and Assignment Modulus.
Added Testcases to validate the parser.

Related Issue

This PR addresses and closes the following Issues:
-Closes #76 Add Parsing for Assignment AND Token
-Closes #77 Add Parsing for Assignment OR Token
-Closes #78 Add Parsing for Assignment XOR Token
-Closes #79 Add Parsing for Assignment Modulus Token

Checklist

Have you added the necessary tests?
Only modified the files mentioned in the related issue(s)?
Are all tests passing?

for more information, see https://pre-commit.ci

ArchitGupta07 · 2024-08-27T06:00:46Z

Updated PR description

samthakur587 · 2024-08-28T06:56:19Z

hii @ArchitGupta07 can you please resolve the merge conflict

samthakur587

can you please resolve merge conflict

for more information, see https://pre-commit.ci

ArchitGupta07 · 2024-08-28T08:21:38Z

Resolved the merge conflict

samthakur587 · 2024-08-28T09:41:04Z

tests/test_translator/test_parser.py

-            }
+            fragColor = vec4(0.0, 0.0, 0.0, 1.0);
+
+            fragColor += vec4(1.0, 1.0, 0.0, 1.0) * isLightOn;


hii @ArchitGupta07 can you please write a new test function for your changes. don't rename and merge your changes in existing test function. can you please write a new function in your test file.

Sorry for the inconvenience. I am new to this and got into some misunderstandings. I will make the necessary changes.

…feat/Assign_operator_parsing

for more information, see https://pre-commit.ci

samthakur587 · 2024-08-29T08:36:50Z

hii @ArchitGupta07 can you please resolve the merge conflicts

for more information, see https://pre-commit.ci

ArchitGupta07 · 2024-08-30T03:42:24Z

Resolved the merge conflicts

…07/98

coderabbitai · 2024-09-05T07:24:30Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

Commits

Files that changed from the base of the PR and between d4a35e6 and a635301.

Files selected for processing (2)

crosstl/src/translator/parser.py (5 hunks)
tests/test_translator/test_parser.py (1 hunks)

_________________________________________________
< Code Wars Episode II: Attack of the Git Clones. >
-------------------------------------------------
 \
  \   (\__/)
      (•ㅅ•)
      / 　 づ

Tip

You can generate walkthrough in a markdown collapsible section to save space.

Enable the reviews.collapse_walkthrough setting in your project's settings in CodeRabbit to generate walkthrough in a markdown collapsible section.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

samthakur587

hii @ArchitGupta07 everything LGTM 🚀

thanks for contribution

ArchitGupta07 and others added 7 commits August 22, 2024 16:56

"Logical Operator Added in Translator frontend

adb9a97

Merge branch 'main' of https://github.com/CrossGL/crosstl

594a8cd

commit

5e625d7

Merge branch 'main' of https://github.com/CrossGL/crosstl

9f11332

Merge branch 'main' of https://github.com/CrossGL/crosstl

97e709c

parsing of assignments operatiors added

f8e9b7a

[pre-commit.ci] auto fixes from pre-commit.com hooks

2710bb5

for more information, see https://pre-commit.ci

NripeshN requested a review from samthakur587 August 27, 2024 14:34

Merge remote-tracking branch 'upstream/main' into pr/98

73f527b

NripeshN self-requested a review as a code owner August 27, 2024 14:36

samthakur587 requested changes Aug 28, 2024

View reviewed changes

ArchitGupta07 and others added 2 commits August 28, 2024 13:45

Merge branch 'main' into feat/Assign_operator_parsing

7f507b6

[pre-commit.ci] auto fixes from pre-commit.com hooks

9da7daf

for more information, see https://pre-commit.ci

Merge branch 'main' of https://github.com/CrossGL/crosstl

80c70f2

samthakur587 requested changes Aug 28, 2024

View reviewed changes

ArchitGupta07 and others added 4 commits August 28, 2024 15:45

Merge branch 'main' of https://github.com/ArchitGupta07/crosstl into …

cfbb6d5

…feat/Assign_operator_parsing

test function updated

795d6b7

new test function created for assignmnent operators

9937d80

[pre-commit.ci] auto fixes from pre-commit.com hooks

eb514bc

for more information, see https://pre-commit.ci

ArchitGupta07 and others added 2 commits August 30, 2024 09:10

Merge branch 'main' into feat/Assign_operator_parsing

6585c95

[pre-commit.ci] auto fixes from pre-commit.com hooks

7969ac8

for more information, see https://pre-commit.ci

ArchitGupta07 requested a review from samthakur587 September 2, 2024 05:54

samthakur587 added 2 commits September 5, 2024 12:43

Merge branch 'main' of github.com:CrossGL/crosstl into pr/ArchitGupta…

8990286

…07/98

fix: fixed test merged

a635301

samthakur587 requested a review from vaatsalya123 as a code owner September 5, 2024 07:24

samthakur587 approved these changes Sep 5, 2024

View reviewed changes

samthakur587 merged commit 7f75249 into CrossGL:main Sep 5, 2024
36 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/assign operator parsing #98

Feat/assign operator parsing #98

ArchitGupta07 commented Aug 25, 2024 •

edited

Loading

ArchitGupta07 commented Aug 27, 2024

samthakur587 commented Aug 28, 2024

samthakur587 left a comment

ArchitGupta07 commented Aug 28, 2024

samthakur587 Aug 28, 2024

ArchitGupta07 Aug 28, 2024

samthakur587 commented Aug 29, 2024

ArchitGupta07 commented Aug 30, 2024

coderabbitai bot commented Sep 5, 2024

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

samthakur587 left a comment

Feat/assign operator parsing #98

Feat/assign operator parsing #98

Conversation

ArchitGupta07 commented Aug 25, 2024 • edited Loading

PR Description

Related Issue

Checklist

ArchitGupta07 commented Aug 27, 2024

samthakur587 commented Aug 28, 2024

samthakur587 left a comment

Choose a reason for hiding this comment

ArchitGupta07 commented Aug 28, 2024

samthakur587 Aug 28, 2024

Choose a reason for hiding this comment

ArchitGupta07 Aug 28, 2024

Choose a reason for hiding this comment

samthakur587 commented Aug 29, 2024

ArchitGupta07 commented Aug 30, 2024

coderabbitai bot commented Sep 5, 2024

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

samthakur587 left a comment

Choose a reason for hiding this comment

ArchitGupta07 commented Aug 25, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)