Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CROW_MAIN macro #273

Closed
The-EDev opened this issue Nov 13, 2021 · 0 comments · Fixed by #280
Closed

Remove CROW_MAIN macro #273

The-EDev opened this issue Nov 13, 2021 · 0 comments · Fixed by #280
Assignees
@luca-schlecker
Labels
feature Code based project improvement

Comments

@The-EDev
Copy link
Member

The-EDev commented Nov 13, 2021 •
edited
Loading

Pretty much the #1 source of confusion and compiler errors. I know it is useful when using multiple source files, but there seems to be a better way of handling this (as discussed on gitter). Not to mention that no one thinks "Oh I love adding extra macros to get my Hello World application to compile".

I will admit that I'm not 100% sure how to do so, but @luca-schlecker has already looked into this, and that this issue is dependent on #264.
@The-EDev The-EDev added the feature Code based project improvement label Nov 13, 2021
@luca-schlecker luca-schlecker self-assigned this Nov 13, 2021
@luca-schlecker luca-schlecker mentioned this issue Nov 17, 2021
Merged
luca-schlecker added a commit that referenced this issue Nov 19, 2021
@luca-schlecker
replace dumb_timer_queue with new task_timer.
f311d99 
fixes #264, lays ground for #273 and #257.

Signed-off-by: Luca Schlecker <luca.schlecker@hotmail.com>
@luca-schlecker luca-schlecker mentioned this issue Nov 19, 2021
Merged
luca-schlecker added a commit that referenced this issue Nov 19, 2021
@luca-schlecker
replace dumb_timer_queue with new task_timer.
de92d28 
fixes #264, lays ground for #273 and #257.

Signed-off-by: Luca Schlecker <luca.schlecker@hotmail.com>
luca-schlecker added a commit that referenced this issue Nov 21, 2021
@luca-schlecker
remove the need for #define CROW_MAIN.
c419b43 
This is achieved using the conts type qualifier as it gives internal linkage.
fixes #273

Signed-off-by: Luca Schlecker <luca.schlecker@hotmail.com>
@luca-schlecker luca-schlecker mentioned this issue Nov 21, 2021
Merged
luca-schlecker added a commit that referenced this issue Nov 21, 2021
@luca-schlecker
remove the need for #define CROW_MAIN.
5823a59 
This is achieved using the conts type qualifier as it gives internal linkage.
fixes #273

Signed-off-by: Luca Schlecker <luca.schlecker@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luca-schlecker luca-schlecker

Labels
feature Code based project improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the need for #define CROW_MAIN CrowCpp/Crow
2 participants
@The-EDev @luca-schlecker