Remove the need for #define CROW_MAIN
#280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is achieved using the conts type qualifier as it gives internal linkage. fixes #273 Signed-off-by: Luca Schlecker <luca.schlecker@hotmail.com>
Signed-off-by: Luca Schlecker <luca.schlecker@hotmail.com>
luca-schlecker
force-pushed
the
wip-luca-schlecker
branch
from
0094a8b
to
e5c7dac
Compare
|
2 PRs that I would consider Historic back to back? Man you need to chill 😂. I canceled the first CI run due to the force push, I'll review once I'm done looking into the websocket spec (Which I'm just finishing) :) |
The-EDev
previously approved these changes
Nov 21, 2021
|
Would you put it in the README or the documentation where the disclaimer saying it was needed was? |
|
The README would probably be best since fewer people check out the documentation. But on the other hand I don't see a problem in putting it in both places. |
Signed-off-by: Luca Schlecker <luca.schlecker@hotmail.com>
|
Canceled CI since no code change happened, will force merge now |
|
@luca-schlecker was there anything you wanted to do before merging? |
|
No, there's nothing I want to add. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luca Schlecker luca.schlecker@hotmail.com
It fixes #273.
This is achieved using the const type qualifier as it gives internal linkage.
"The const qualifier used on a declaration of a non-local non-volatile non-template (since C++14) non-inline (since C++17) variable that is not declared extern gives it internal linkage." (cppreference.com)
The release script didn't need an update, as it just worked with the changes. The mime-type script was changed to reflect the needed changes.
I also deleted all references to
#define CROW_MAINin the documentation, but I didn't take a look at it. Could you please confirm it not breaking anything horribly @The-EDev?The examples compile fine and my test application also worked without a problem.