Skip to content

Commit

Permalink
Merge pull request #180 from Crunch-io/coverage-attempt
Browse files Browse the repository at this point in the history
Coverage attempt
  • Loading branch information
slobodan-ilic authored Oct 8, 2019
2 parents f4d0ca7 + 08a78b0 commit 96c200e
Show file tree
Hide file tree
Showing 8 changed files with 1,459 additions and 14 deletions.
2 changes: 1 addition & 1 deletion src/cr/cube/cube.py
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ def raw_cube_array(self):
return array

@lazyproperty
def _flat_values(self):
def _flat_values(self): # pragma: no cover
"""Return tuple of mean values as found in cube response.
This property must be implemented by each subclass.
Expand Down
14 changes: 5 additions & 9 deletions src/cr/cube/dimension.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ def _dimensions(self):
This composed tuple is the source for the dimension objects in this
collection.
"""
raise NotImplementedError("must be implemented by each sublass")
raise NotImplementedError(
"must be implemented by each subclass"
) # pragma: no cover


class AllDimensions(_BaseDimensions):
Expand Down Expand Up @@ -755,7 +757,9 @@ def fill(self):
A str value must be a hash character ("#") followed by six hexadecimal digits.
Three-character color contractions (like "#D07") are not valid.
"""

fill = self._element_transforms_dict.get("fill")

if not fill:
return None
return fill
Expand Down Expand Up @@ -931,14 +935,6 @@ def addend_idxs(self):
for addend_id in self.addend_ids
)

@property
def is_insertion(self):
"""True if this item represents an insertion (e.g. subtotal).
Unconditionally True for _Subtotal objects.
"""
return True

@lazyproperty
def label(self):
"""str display name for this subtotal, suitable for use as label."""
Expand Down
Loading

0 comments on commit 96c200e

Please sign in to comment.