-
Notifications
You must be signed in to change notification settings - Fork 12
Migrating PGO CLI kuttl tests to chainsaw #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We can use Kyverno policies to facilitate testing with different image repos.
These are helpful templates to use when testing the PGO CLI
Instructions for how to run the tests
The chainsaw-show Test should remove resources after it completes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. A few questions.
postgres: '17' | ||
|
||
images: | ||
psql: 'registry.developers.crunchydata.com/crunchydata/crunchy-postgres:ubi9-17.5-2520' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Should this be updated to a more recent image?
- name: Sleep for 10s | ||
try: | ||
- sleep: | ||
duration: 10s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Is 10s enough for these sleeps? I wonder if the step length or something else is still coming into play here.
- name: Verify COMMAND_OPTS matches "--stanza=db --repo=1" | ||
bindings: | ||
- name: selector | ||
value: (replace_all( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 This may well be the best way to do this, but nesting the replace_all
functions feels funny to me.
These are the first round of kuttl tests migrated to chainsaw. The structure is a single test for each kubectl-pgo command