Skip to content

Conversation

philrhurst
Copy link
Collaborator

These are the first round of kuttl tests migrated to chainsaw. The structure is a single test for each kubectl-pgo command

  • backup
  • create
  • delete
  • show
  • version

@philrhurst philrhurst marked this pull request as ready for review August 27, 2025 16:10
Copy link
Contributor

@tjmoore4 tjmoore4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. A few questions.

postgres: '17'

images:
psql: 'registry.developers.crunchydata.com/crunchydata/crunchy-postgres:ubi9-17.5-2520'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Should this be updated to a more recent image?

- name: Sleep for 10s
try:
- sleep:
duration: 10s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Is 10s enough for these sleeps? I wonder if the step length or something else is still coming into play here.

- name: Verify COMMAND_OPTS matches "--stanza=db --repo=1"
bindings:
- name: selector
value: (replace_all(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 This may well be the best way to do this, but nesting the replace_all functions feels funny to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants