-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Add keyType to postgres s3 helm template #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
keyType was missing from the list of s3 config fields.
This change allows us to use role based access when running within EKS. |
You would need to add this to the |
# keySecret: "" | ||
# # keyType can be configured to enable IAM integration via AssumeRole |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# # keyType can be configured to enable IAM integration via AssumeRole | |
# # keyType can be configured to enable IAM integration via AssumeRole | |
# # For more info, see the documentation at https://access.crunchydata.com/documentation/postgres-operator/v5/tutorial/backups/#using-an-aws-integrated-identity-provider-and-role |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let me just get a backpatch ready for our devel branch
* Add keyType to postgres s3 helm template keyType was missing from the list of s3 config fields.
* Add keyType to postgres s3 helm template keyType was missing from the list of s3 config fields.
* Add keyType to postgres s3 helm template keyType was missing from the list of s3 config fields.
keyType was missing from the list of s3 config fields.