Skip to content

Add keyType to postgres s3 helm template #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

jyanez900
Copy link
Contributor

keyType was missing from the list of s3 config fields.

keyType was missing from the list of s3 config fields.
@toscott
Copy link

toscott commented Oct 19, 2022

This change allows us to use role based access when running within EKS.

@benjaminjb
Copy link
Contributor

You would need to add this to the values.yaml too, right?

# keySecret: ""
# # keyType can be configured to enable IAM integration via AssumeRole
Copy link
Contributor

@benjaminjb benjaminjb Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# # keyType can be configured to enable IAM integration via AssumeRole
# # keyType can be configured to enable IAM integration via AssumeRole
# # For more info, see the documentation at https://access.crunchydata.com/documentation/postgres-operator/v5/tutorial/backups/#using-an-aws-integrated-identity-provider-and-role

Copy link
Contributor

@benjaminjb benjaminjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let me just get a backpatch ready for our devel branch

@benjaminjb benjaminjb merged commit 2f0fdb8 into CrunchyData:main Mar 22, 2023
ValClarkson added a commit to ValClarkson/postgres-operator-examples that referenced this pull request Jul 14, 2023
* Add keyType to postgres s3 helm template

keyType was missing from the list of s3 config fields.
tjmoore4 pushed a commit to tjmoore4/postgres-operator-examples that referenced this pull request Jul 17, 2023
* Add keyType to postgres s3 helm template

keyType was missing from the list of s3 config fields.
tjmoore4 pushed a commit to tjmoore4/postgres-operator-examples that referenced this pull request Jul 17, 2023
* Add keyType to postgres s3 helm template

keyType was missing from the list of s3 config fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants