Allow to install in PHP8 environment #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
func0der
reviewed
Mar 4, 2022
| @@ -38,6 +38,6 @@ private function isValidDatetime(string $value): bool | |||
| $date = DateTime::createFromFormat($this->datetimeFormat, $value, new DateTimeZone($this->datetimeZone)); | |||
| $errors = DateTime::getLastErrors(); | |||
|
|
|||
| return $date && $errors['warning_count'] === 0 && $errors['error_count'] === 0; | |||
| return $date && !$errors; | |||
There was a problem hiding this comment.
This breaks the library: https://3v4l.org/hFvIJ
I do not know why php.net tells us that the function would return false, but it does not. Neither in 7.4, nor 8.0, nor 8.1 (see the 3v4l)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.