-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easier to build #46
Conversation
I cleaned up a bit compilation tasks. - Merged both 'inject-player' and 'inject-index' into 'inject-html'. - Added a 'compile' task Added tasks to help install & build - build handles ffmpeg lib - run launches the app Also updates README to reflect this changes. Also added nodewebkit as a dependency in package.json. It is a dependency after all. Please test the build and run scripts on different platforms. I tested it on Windows and it works just fine.
@ivantodorovich the nodewebkit binary name in mac is |
Please test. Although I think it should work properly on every platform, since it falls back nicely. It now makes use of npm scripts to install and run.
Fixed. I think it's perfect now. Install
Run
Simple. |
|
||
"scripts": { | ||
"install": "gulp build", | ||
"start": "nodewebkit . -- --debug" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this right? sorry cant test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be. Does not work for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm install no jode con el que instala las dependencias? porque no lo cambias a npm build? o cada vez que se escriba npm install para compilar va a bajar las dependencias de nuevo?
No uso mucho npm asi que ni idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cada vez que se ejecuta npm install
, además de instalar las dependencias y hacer lo que siempre hace, va a hacer correr gulp build
. Funciona como un hook al comando install
, no lo reemplaza.
Probalo y después me contás :)
I'm currently working on extending this branch to implement scripts for building the standalone executable. Currently It's only supporting win32. Will add other platforms once I get this polished. @Cuevana how did you set the executable's icon on the build? |
@ivantodorovich I'm not sure if this is what you are looking for, but to pack all in an executable i found this, https://github.com/rogerwang/node-webkit/wiki/How-to-package-and-distribute-your-apps at the bottom it says that you can use "Enigma Virtual Box" By the way, i'm having troubles to understand how to pack the app, i would like to do some custom modifications to it, and i think you may know how to do what i need, it's my whatsapp if you have a minute to discuss this: (3942 546 59 083+) Al verez, o sea, empezá por el + y terminas en 93. Te hago una consulta y si te parece posible vemos como arreglamos. Saludos. |
@Foxito agregame a Hangouts, o por mail. |
@ivantodorovich here is a good tutorial about how to hack the .exe to change the icon: http://www.wikihow.com/Change-the-Icon-for-an-Exe-File PS: ya te mande mail. |
Great work @ivantodorovich. We used https://github.com/geo8bit/nodebob for Windows build, maybe we can add it to the build process. |
I made binaries for Linux 32-bit copying and modifying lines of code (changing "win32" with "ia32/linux32" and removing ".exe"). Is it possible to build for all platforms, or build for a particular platform, using the same code to avoid redundant and repetitive lines? |
Not really. I will made the script for both, linux 32 and 64 bits. Maybe ill made a pull request this wendsday. This script, will include a desktop and icons files acording the freedesktop specification. |
At the time I made this PR this project didn't work: https://github.com/mllrsohn/node-webkit-builder But now it does. We should add it as a @cesasol let me know if you wanna handle it. |
I do, at least for GNU/Linux distributions |
Using the Example taken of https://github.com/mllrsohn/node-webkit-builder :
You still need to handle |
@ivantodorovich check out how Flixtor build using https://github.com/TorrentLookup/Flixtor/blob/master/Gruntfile.js I'm sure you can adapt this to the tasks you added. |
I cleaned up a bit compilation tasks.
Added tasks to help install & build
Also updates README to reflect this changes.
Also added nodewebkit as a dependency in package.json.
It is a dependency after all.
Please test the build and run scripts on different platforms. I tested it on Windows and it works just fine.