Skip to content

FromPackageJson builders and factories #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2022
Merged

FromPackageJson builders and factories #47

merged 1 commit into from
Jun 18, 2022

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented May 31, 2022 •
edited
Loading

node-specific builders and factories, that can make models from Package.json-data

TODO

  • implement Tool
  • implement Component
  • have tests for all the new builders and factories
  • squash all commits
  • update capabilities in the README

impact

  • changes:
    • renamed the Resources struct to _Resources - as it was marked as internal already.
  • added
    • PackageJson-specific builders and factories
  • misc
    • hardened some tests
    • refactored internal indexes

@jkowalleck jkowalleck force-pushed the builders branch 2 times, most recently from 89829c9 to a7a5bcd Compare June 5, 2022 11:11
Base automatically changed from 1.0-dev to main June 8, 2022 20:40
jkowalleck
jkowalleck commented Jun 8, 2022
View reviewed changes
jkowalleck
jkowalleck commented Jun 10, 2022
View reviewed changes
@jkowalleck jkowalleck changed the title DEMO: builders FromPackageJson builders and factories Jun 17, 2022
@jkowalleck jkowalleck force-pushed the builders branch 6 times, most recently from c52e2d3 to fa22206 Compare June 18, 2022 06:58
@jkowalleck jkowalleck marked this pull request as ready for review June 18, 2022 06:59
@jkowalleck jkowalleck requested a review from a team as a code owner June 18, 2022 06:59
@jkowalleck jkowalleck added this to the v1.0 milestone Jun 18, 2022
@jkowalleck
builders
0cd9c6f 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added the enhancement New feature or request label Jun 18, 2022
@jkowalleck jkowalleck merged commit 8fab311 into main Jun 18, 2022
@jkowalleck jkowalleck deleted the builders branch June 18, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jkowalleck