slacked pipenv parser #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkowalleck
commented
Oct 28, 2021
| @@ -56,4 +56,3 @@ class PipEnvFileParser(PipEnvParser): | |||
| def __init__(self, pipenv_lock_filename: str): | |||
| with open(pipenv_lock_filename) as r: | |||
| super(PipEnvFileParser, self).__init__(pipenv_contents=r.read()) | |||
| r.close() | |||
There was a problem hiding this comment.
was not needed.
the stream was closed already automatically, as soon as the streams context was exited (__exit__()).
context exit happened as soon as the with block was finished.
|
|
||
| for package_name in pipfile_lock_contents['default'].keys(): |
There was a problem hiding this comment.
simplified by iterating over the dict's items as (key, value) tuple.
| # Add download location with hashes stored in Pipfile.lock | ||
| if 'hashes' in package_data.keys(): |
There was a problem hiding this comment.
this is a very slow way to test for existance of keys.
used dict.get() - which returns None if the key does not exist ...
this way the whole process was slacked and more forgiving to possible malformed pipenv files ...
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
madpah
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see the comments in the changed file for reasons for this PR