Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POETRY] option to omit dev-requirements #374

Closed
rugleb opened this issue Jun 20, 2022 · 8 comments
Closed

[POETRY] option to omit dev-requirements #374

rugleb opened this issue Jun 20, 2022 · 8 comments
Labels
enhancement New feature or request source: poetry

Comments

@rugleb
Copy link

rugleb commented Jun 20, 2022

Hi!
I'm using this command: poetry run cyclonedx-bom -p -i poetry.lock -o cyclonedx-bom.xml --force which generates report with all requirements.
I think we need flag which disable scan of dev-requirements.

@jkowalleck jkowalleck added the enhancement New feature or request label Jun 20, 2022
@jkowalleck
Copy link
Member

jkowalleck commented Jun 20, 2022

Sounds reasonable.

Pull requests are welcome.
Do you want to give it a try?

@jkowalleck jkowalleck changed the title Skip dev-requirements in report [POETRY] Skip dev-requirements in report Jun 20, 2022
@jkowalleck jkowalleck changed the title [POETRY] Skip dev-requirements in report [POETRY] option to omit dev-requirements Jun 20, 2022
@camillem
Copy link

Hi, I have a need which is similar but a bit different : that would be to have dev-requirements dependencies not omitted but flagged as such. May be by setting the field
https://cyclonedx.org/docs/1.4/json/#components_items_scope to "optional" for dev-requirements and to "required" for others.

@jkowalleck
Copy link
Member

is there some property in CycloneDX that describes a component as a "dev-dependency"? I suppose not.

@madpah So to publish this as a custom property, it would start with a taxonomy definition. ala cdx:npm:package:development in https://github.com/CycloneDX/cyclonedx-property-taxonomy/blob/main/cdx/npm.md

@camillem
Copy link

Would it be something like that https://github.com/camillem/cyclonedx-property-taxonomy/blob/main/cdx/poetry.md ?
(and should I open a new issue, as we have diverged a bit from the initial topic?)

@jkowalleck
Copy link
Member

jkowalleck commented Sep 13, 2022

re: #374 (comment)

[...] should I open a new issue [...]

yes. an own issue https://github.com/CycloneDX/cyclonedx-property-taxonomy would be good, to discuss the initial needs.
The PR would then be created by the @CycloneDX/python-maintainers

and yes, an own issue regarding poetry driven properties would be good, too. - as the original request in this issue was about omitting data.

@jkowalleck
Copy link
Member

jkowalleck commented Oct 3, 2022

@camillem , @rugleb , the proposal was made merged - see CycloneDX/cyclonedx-property-taxonomy#29

if you'd like, you could start with a implementation. or a draft, or ProveOfConcept. :-D

@camillem
Copy link

@jkowalleck : thanks! Currently trying to come up with a draft/ PoC :-)

@jkowalleck
Copy link
Member

@rugleb @camillem this issue was superseded by #474

@jkowalleck jkowalleck closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request source: poetry
Projects
None yet
Development

No branches or pull requests

3 participants