Skip to content

Conversation

9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Mar 3, 2011

No description provided.

@donc
Copy link
Collaborator

donc commented Mar 3, 2011

Bug 5080 cannot be applied until opEquals is fixed. I think the others are ready.

@9rnsr
Copy link
Contributor Author

9rnsr commented Mar 3, 2011

Patch of issue 5080 changes only implicit conversion behavior. See Steven's comment #9.
http://d.puremagic.com/issues/show_bug.cgi?id=5080#c9

@donc
Copy link
Collaborator

donc commented Mar 3, 2011

Please ignore Steven's comment. It's misleading. opEquals is WRONG. This patch prevents the only known workaround.
The problem is, that we have legal code which compiles right now because of this bug. Putting this patch in right will break existing code. And the problem is NOT with the code, or with this patch; it's with opEquals. BTW almost all compiler regressions are like this: they break something which used to work, but for incorrect reasons. The fact they worked for incorrect reasons does not stop it being a regression. opEquals needs to be fixed first.

@9rnsr
Copy link
Contributor Author

9rnsr commented Mar 3, 2011

Thanks for the detailed explanation. I'm looking forward to your fix.

@WalterBright
Copy link
Member

In the future, please have a separate pull request for each issue.

@WalterBright
Copy link
Member

5178 is incorrect, see the bugzilla entry for it.

@9rnsr
Copy link
Contributor Author

9rnsr commented Apr 1, 2011

I understood your reason. I also think that converting from rvalue to lvalue is correct behavior.
Apart from that, it seems to me that StructLiteral should be rvalue.
This behavior is need to write resource management wrapper type like std.typecons.Unique.
I posted issue 5769 with same reason.
What do you think?

braddr pushed a commit to braddr/dmd that referenced this pull request Sep 15, 2011
braddr pushed a commit to braddr/dmd that referenced this pull request Sep 15, 2011
UplinkCoder added a commit to UplinkCoder/dmd that referenced this pull request Aug 14, 2016
UplinkCoder added a commit to UplinkCoder/dmd that referenced this pull request Aug 31, 2016
UplinkCoder added a commit to UplinkCoder/dmd that referenced this pull request Sep 1, 2016
UplinkCoder added a commit to UplinkCoder/dmd that referenced this pull request Sep 4, 2016
UplinkCoder added a commit to UplinkCoder/dmd that referenced this pull request Sep 19, 2016
UplinkCoder added a commit to UplinkCoder/dmd that referenced this pull request Sep 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants