fix issue 10542 - implicitly generated class ctor doesnt inherit base class ctor attributes #2297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| TypeFunction *tf = new TypeFunction(NULL, NULL, 0, LINKd, 0); | ||
| tf->isnothrow = btf->isnothrow; | ||
| tf->purity = btf->purity; | ||
| tf->trust = btf->trust; |
There was a problem hiding this comment.
In D2, baseClass->ctor may be template, so (CtorDeclaration *)baseClass->ctor would be wrong result...
I think following code would be better:
if (FuncDeclaration *f = resolveFuncCall(loc, sc, baseClass->ctor, NULL, NULL, NULL, 1))
{
Type *tf = new TypeFunction(NULL, NULL, 0, LINKd, f->storage_class);
...resolveFuncCallreturns actually instantiated function even whenbaseClass->ctoris template.TypeFunctionconstructor sets its fields by usingStorageClass stcparameter. In this case, you can just passf->storage_classto it.
There was a problem hiding this comment.
This will work only for @safe nothrow pure this(), but not for this() @safe nothrow pure since they are part of the TypeFunction then.
class ctor attributes
9rnsr
added a commit
that referenced
this pull request
Jul 4, 2013
fix issue 10542 - implicitly generated class ctor doesn't inherit base class ctor attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=10542