[DDMD] Disable constructor and destructor mangling for C++ on win32 #2816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1629,7 +1629,7 @@ STATIC void cpp_symbol_name(symbol *s) | |||
| } | |||
| } | |||
| #endif | |||
| #if MARS | |||
| #if MARS && 0 | |||
There was a problem hiding this comment.
Need comment saying why you're doing this. The one from the discussion page will work.
There was a problem hiding this comment.
I've removed it completely instead. If we ever do get constructors to work cross-language, chances are by then we will have moved the mangling into the frontend anyway.
There was a problem hiding this comment.
I kinda like the comment in case this comes up again - nobody is going to look through the history for it.
There was a problem hiding this comment.
Ok, done, although chances are if anybody tries to add c++ ctor support, it will be after this has been re-implemented in the frontend.
|
Added comment. |
|
All green. |
ghost
pushed a commit
that referenced
this pull request
Nov 20, 2013
[DDMD] Disable constructor and destructor mangling for C++ on win32
ghost
merged commit
|
Thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It mangles correctly, but the ABI doesn't match, leading to copious segfaults. At least with the wrong mangling you get link errors.