Issue 11629 - [CTFE] crash on AA.rehash

[9rnsr]

https://d.puremagic.com/issues/show_bug.cgi?id=11629

[yebblies]

toBuiltinAAType isn't actually called from anywhere at the moment, is it possible the rest of the code takes other steps to preserve the type?

[9rnsr]

Maybe impossible. The type AssociativeArray!(K, V) is set in TypeAArray::dotExp, for rehash member function call. But CTFE will generate pure AA literal, and it should be typed as Taarray. So I think that using toBuiltinAAType in scrubReturnValue would be the most better way.

[9rnsr]

@donc How about this change?

[yebblies]

I'm not sure about this. The bug is arguably that hasNonConstPointers assumes TOKassocarrayliteral's type is always TypeAArray. I wouldn't be surprised to find other places that assume this (these will be fixed by changing the type during scrubbing of course), and places inside ctfe as well.

Of course, pull #2856 fixes this as well.