Refactor: simplify setting of useArrayBounds #4562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| char useArrayBounds; // 0: no array bounds checks | ||
| // 1: array bounds checks for safe functions only | ||
| // 2: array bounds checks for all functions | ||
| char useArrayBounds; // enum BOUNDSCHECK |
There was a problem hiding this comment.
Should use BOUNDSCHECK as the type
WalterBright
force-pushed
the
refactorBoundscheck
branch
2 times, most recently
from
003d252 to
3eee9df
Compare
|
Good. When I add boundcheck I hadn't really changed anything serious with dmd before so I tried to not rock the boat too much and made it very similar to what was already there, though I was cognizant of how ugly it was when I added it (I believe @AndrejMitrovic pointed it out during the review too). This is much better. |
|
Making things flow better is always an ongoing learning process, for myself included. I generally hate all the code I wrote more than a couple years back. |
|
Auto-merge toggled on |
yebblies
added a commit
that referenced
this pull request
Apr 6, 2015
Refactor: simplify setting of useArrayBounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor only - should not be any change in functionality.