Issue 15352 - template arguments matching error with delegates #5275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Tuple u2 = isTuple(o2); | ||
| enum debugPrint = 0; | ||
|
|
||
| auto t1 = isType(o1); |
There was a problem hiding this comment.
Only tangentially related, but at some point it would make sense to optimize match. It shows up on the profile for building some template-heavy programs. Specifically, some of the isXXX checks can be done later, and there might be something to gain by directly comparing the kind members (but obviously not for the expression vs. symbol case).
There was a problem hiding this comment.
Interesting. I opened a new PR #5276 to do the small optimization. Then, I'll remove the match() changes from this PR.
1. `match()` function relies on `Expression.equals()`. Add `FuncExp.equals` for the identity comparison of two `FuncExp`s. 2. When a `FuncLiteralDeclaration` is listed directly in template arguments, it needs to be converted to `FuncExp` to be able to match `TemplateValueParameter`.
|
Auto-merge toggled on |
WalterBright
added a commit
that referenced
this pull request
Nov 28, 2015
Issue 15352 - template arguments matching error with delegates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=15352
match()function relies onExpression.equals(). AddFuncExp.equalsfor the identity comparison of twoFuncExps.FuncLiteralDeclarationis listed directly in template arguments, it needs to be converted toFuncExpto be able to matchTemplateValueParameter.