-
-
Notifications
You must be signed in to change notification settings - Fork 655
some changes to ddoc #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some changes to ddoc #770
Conversation
…encode things and serves no other purpose. I deleted it all.
@@ -288,12 +286,36 @@ void Module::gendocfile() | |||
emitMemberComments(sc); | |||
} | |||
|
|||
//printf("BODY= '%.*s'\n", buf.offset, buf.data); | |||
Macro::define(¯otable, (unsigned char *)"BODY", 4, buf.data, buf.offset); | |||
// if I did the character encoding right here, I think we'd be in business |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea what this comment means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Sun, Mar 18, 2012 at 08:01:23PM -0700, Walter Bright wrote:
I have no idea what this comment means.
I think I was talking to myself...
The idea is to do the special character encoding right
before macro expansion.
This way, everything the user typed in their doc comment
gets encoded properly*, but the macros can still be used
to output raw HTML.
- if you type
/// A < B
The proper output for html is
A < B
So the user sees in their browser the same text you typed here.
A recent thread in D.learn reminded me of this. Any chance you could break just this change out into a separate pull request? This hits users all the time. |
Not sure this has enough design behind it; I fear one day we'll find other stuff that's "almost" doable with tables but not quite. Anyhow, |
On Tue, Sep 25, 2012 at 08:45:25AM -0700, Andrei Alexandrescu wrote:
This needs a solution, so perhaps we should start discussing the The status quo makes documenting an XML library with examples extremely We need to find something that works. The character table is a pretty good solution,
Yeah, I should start it over since it's been a long time and I forgot Let's close this one and make a new pull later. |
Inspired by this |
exp, expm1, exp2 return 'inf' for targets that don't use iasm.
Here's some details:
http://forum.dlang.org/thread/igiihgtmsaptfvfbtozz@forum.dlang.org
These are breaking changes, but everyone I've asked has thought
they are good ideas, and it is pretty easy to fix what it breaks.
There's two things in here:
change PSYMBOL to give both toChars() and toPrettyChars(), for better anchor generation
kill the embedded html feature, since it is more trouble than its worth. Instead, we'll use the ESCAPES system to encode input in a user defined fashion and macros to output html.
Aside from the expected breakage, it seems to work very well.