Skip to content

Conversation

s-ludwig
Copy link
Member

The commits by @Abscissa have already been reviewed as part of #572.

s-ludwig and others added 25 commits June 26, 2015 10:45
Accessing a non-existent key of a Json object inserts a Type.undefined entry if no entry of that name exists. This change includes this case and treats the key as unset.
…nd --data=lib-files (for dependency libs)

This is needed because compilers/linkers often expect the two types of libs to be passed in differently: System/installed libs (--data=libs) must be provided like "-Lname" which the linker automatically converts to "path/lib*.a". Non-installed libs, such as dub dependencies, are passed with full filepath just like an object file. Your linker may vary.
…ectly for a compiler's commandline. Use --data-format=list to get the old list-style output.
…rary or a staticLibrary, then --data=libs never emits any output.
@s-ludwig
Copy link
Member Author

Main changes to "dub describe", apart from #572, is the addition of a "targets" field that lists the binary build targets, and making the API statically typed (vs. the old Json based API).

@s-ludwig
Copy link
Member Author

Pulling to prepare a beta-2 release with this included.

s-ludwig added a commit that referenced this pull request Jun 30, 2015
Improve "dub describe" and use BitFlags
@s-ludwig s-ludwig merged commit 8f422e3 into master Jun 30, 2015
@Abscissa
Copy link
Contributor

Awesome :)

Is there any chance of #593 also getting into 0.9.24? That would also be really nice to have.

@s-ludwig s-ludwig deleted the refactor1 branch July 1, 2015 15:18
@MartinNowak
Copy link
Member

No we have all those fancy describe functions with lots of description and plenty of tests and I still can't get a plain list of dependencies. Are you sure this goes in the right direction?
This detailed level of introspection is better handled by using dub as library IMO. Making the latter more accessible/stable will improve the quality of dub while adding many more knobs and switches creates a maintenance nightmare.

@Abscissa
Copy link
Contributor

@MartinNowak: These "knobs and switches" are necessary to decouple package management from build system, which is necessary for other reasons. Whether or not there are other things also needed, like getting a plain list of deps (a good idea, btw), is a separate matter and has no bearing on whether other features are worthwhile. I've been trying to hold back on this, but honestly, I'm getting tired of your constant pushback and naysaying at nearly every attempt to improve anything in D. Progress doesn't come from blocking improvements.

@MartinNowak
Copy link
Member

Well have you even considered to use dub as library to get the data?
We have limited resources so it's important to think twice before increasing maintenance cost.
Also I don't clearly see the goal (or the outline of a plan) for this rather pedantic build tool vs. package manager distinction.

@Abscissa
Copy link
Contributor

Abscissa commented Nov 2, 2015

On 10/31/2015 10:34 AM, Martin Nowak wrote:

Well have you even considered to use dub as library to get the data?

You've brought that up several times before, and I've already addressed
it. I'm done bikeshedding.

We have limited resources so it's important to think twice before increasing maintenance cost.
Also I don't clearly see the goal (or the outline of a plan) for this rather pedantic build tool vs. package manager distinction.

Where's the goal/plan for conflating the two? Again, this has already
been discussed before, ad nauseum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants