Logging changes #621
Merged
Logging changes #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump! |
|
Looks good. The only thing I wonder that might still be worth to have is the "Linking..." message, so that failures can be immediately associated to either the compiler or the linker. Thoughts? |
|
Yes. It's the one I was most worried of removing. |
|
Thinking about the latter, since the build type is also constant across all targets, that could also be moved to a single message at the beginning. |
|
Reintroduced the Linking... messages. |
- display the generate .sln filename which is usually the one you reach for after - using the "solution" word instead of "project" since "projects" refers to parts of a solution in VS linguo.
- "FAIL" message is now a diagnostic - Align various versions of the same message on Building configuration "%s", build "%s"... for consistency. - Remove messages like: Running DMD... Linking... Compiling using GDC...
|
Rebased. |
|
Okay, thanks! I'll have a look at that message at the beginning right now. |
s-ludwig
added a commit
that referenced
this pull request
Jul 16, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #608