Fix #384: Switch the working directory when executing build commands. #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only solution to #618 that doesn't require larger restructurings looks like it is to insert updates to the environment vars as commands into the command array. In that case it would make sense to also insert "cd" commands there to change directories. I'm not sure if this can be considered particularly pretty, but it would mean that the command lists stay naturally composable, reducing the risk that such issues occur in other parts of the code (VisualD project generator?). |
jacob-carlborg
added a commit
to jacob-carlborg/dmd
that referenced
this pull request
Mar 17, 2019
When DMD is used as a Dub dependency and generates the DMD version as a pre generate command. Dub will execute this command in the root package working directory instead of the DMD package directory. This will result in the wrong version, that is, it will pick up the git tag of the root package instead of the DMD package. This looks related: dlang/dub#659.
jacob-carlborg
added a commit
to jacob-carlborg/dmd
that referenced
this pull request
Mar 17, 2019
When DMD is used as a Dub dependency and generates the DMD version as a pre generate command. Dub will execute this command in the root package working directory instead of the DMD package directory. This will result in the wrong version, that is, it will pick up the git tag of the root package instead of the DMD package. This looks related: dlang/dub#659.
jacob-carlborg
added a commit
to jacob-carlborg/dmd
that referenced
this pull request
Mar 17, 2019
When DMD is used as a Dub dependency and generates the DMD version as a pre generate command. Dub will execute this command in the current working directory, which usually is the root package working directory, instead of the DMD package directory. This will result in the wrong version, that is, it will pick up the git tag of the root package instead of the DMD package. This looks related: dlang/dub#659.
jacob-carlborg
added a commit
to jacob-carlborg/dmd
that referenced
this pull request
Mar 17, 2019
When DMD is used as a Dub dependency and generates the DMD version as a pre generate command. Dub will execute this command in the current working directory, which usually is the root package working directory, instead of the DMD package directory. This will result in the wrong version, that is, it will pick up the git tag of the root package instead of the DMD package. This looks related: dlang/dub#659.
jacob-carlborg
added a commit
to jacob-carlborg/dmd
that referenced
this pull request
Mar 17, 2019
When DMD is used as a Dub dependency and generates the DMD version as a pre generate command. Dub will execute this command in the current working directory, which usually is the root package working directory, instead of the DMD package directory. This will result in the wrong version, that is, it will pick up the git tag of the root package instead of the DMD package. This looks related: dlang/dub#659.
|
Superseeded by #1820 (I don't have write access so someone will need to close). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that, due to #658, this only works for (pre|post)GenerateCommands, not (pre|post)BuildCommands. When #658 is fixed, this PR should automatically work for all four (pre|post)(Build|Generate)Commands.