Let dub.selections.json always have precedence. Fixes #754. #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to merge this after a self-review. Not sure if the peer-review development process is realistic for DUB at this point. I can't meaningfully continue to work on important things, because that would end up with merge conflicts all over the place due to PRs concerning the same code portions piling up. |
s-ludwig
added a commit
that referenced
this pull request
Feb 10, 2016
…endency-fail Let dub.selections.json always have precedence. Fixes #754.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path based dependencies in dub.sdl/json used to have precedence over dub.selections.json, leading to the error message in #754.