Fix emplace for static arrays #1567
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs remerge. And it's too complicated. CLosing. Will re-open soon. |
|
@monarchdodra any progress on this one? |
Ah... Sorry, I relocated... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue 10973 emplace internal error
http://d.puremagic.com/issues/show_bug.cgi?id=10973
Addresses 10978 Better support of emplace for structs with immutable members
http://d.puremagic.com/issues/show_bug.cgi?id=10978
Basically,
emplacenow explicitly supports static arrays. This was quite difficult, as static arrays have semantics un-like anything else. In particular, there are very different semantics for construction, assignment, or slice-assignement.But I think I got almost everything.
I addressed 10978, in the sense that the code will now work, but is not optimal.
I apologize in advance if this is complicated, I saw no way arround it.
BTW: This fixes what I think is a blocker regression.