Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jupyter notebook version of caching_nodes example #444

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

alti-tude
Copy link
Contributor

Add jupyter notebook version of caching_nodes example #247

Changes

  • Add jupyter notebook version of caching_nodes example
  • Add "examples/**/hamilton-env" to .gitignore to ignore the autogenerated virtual environments.

How I tested this

Manually ran through the notebook and verified results

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@skrawcz
Copy link
Collaborator

skrawcz commented Oct 5, 2023

@alti-tude see https://github.com/DAGWorks-Inc/hamilton/blob/main/developer_setup.md for setting up pre-commit locally.

Otherwise looking good, thanks!

@alti-tude
Copy link
Contributor Author

@alti-tude see https://github.com/DAGWorks-Inc/hamilton/blob/main/developer_setup.md for setting up pre-commit locally.

Otherwise looking good, thanks!

Yep. Fixed it. Thanks!

@skrawcz skrawcz merged commit 40c0c6b into DAGWorks-Inc:main Oct 5, 2023
21 checks passed
@skrawcz
Copy link
Collaborator

skrawcz commented Oct 5, 2023

Thanks! Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants