Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DD-420 multi license UI #73

Merged
merged 8 commits into from
May 26, 2021
Merged

DD-420 multi license UI #73

merged 8 commits into from
May 26, 2021

Conversation

JingMa87
Copy link

@JingMa87 JingMa87 commented May 10, 2021 •
edited
Loading

What this PR does / why we need it: Add multi-license functionality to UI.

Which issue(s) this PR closes:

Closes #

Special notes for your reviewer:

Suggestions on how to test this:

  1. Add a test dataset in the UI
  2. Add a license through the API, eg the one below:
{
  "name": "Apache License 1.0",
  "shortDescription": "This is the original Apache License which applies only to very old versions of Apache packages (such as version 1.2 of the Web server).",
  "uri": "https://www.apache.org/licenses/LICENSE-1.0",
  "iconUrl": "https://itgala.xyz/wp-content/uploads/2017/10/Apache-HTTP-Server.png",
  "active": false
}
  1. Change the license in the UI.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@PaulBoon PaulBoon changed the base branch from develop to multi-license May 10, 2021 11:44
@janvanmansum janvanmansum merged commit 83b21f0 into DANS-KNAW:multi-license May 26, 2021
PaulBoon pushed a commit to PaulBoon/dataverse that referenced this pull request Mar 24, 2022
@qqmyers
DANS-KNAW#73 - avoid empty aria-label on first value
333ecfe 
(first value gets the real label, repeat values get the aria label
'Additional Entry')
PaulBoon pushed a commit to PaulBoon/dataverse that referenced this pull request Mar 24, 2022
@qqmyers
DANS-KNAW#73 fix hostDataverse label reference
e6466f3
PaulBoon pushed a commit to PaulBoon/dataverse that referenced this pull request Mar 24, 2022
@qqmyers
DANS-KNAW#73 remove unused hiddenReason input (had no label)
d087264 
Conflicts:
	src/main/webapp/dataset.xhtml
PaulBoon pushed a commit to PaulBoon/dataverse that referenced this pull request Mar 24, 2022
@qqmyers
DANS-KNAW#73 Terms of Access label
4590ec8
PaulBoon pushed a commit to PaulBoon/dataverse that referenced this pull request Mar 24, 2022
@qqmyers
DANS-KNAW#73 - thumbnail and prov labels
e1770c6
PaulBoon pushed a commit to PaulBoon/dataverse that referenced this pull request Mar 24, 2022
@qqmyers
DANS-KNAW#73 - labels for cvv inputs
a532764
PaulBoon pushed a commit to PaulBoon/dataverse that referenced this pull request Mar 24, 2022
@qqmyers
DANS-KNAW#73 render dialog only when needed, fix compute table header
65eb2f4 
a link is empty in the dialog if the dataset doesn't have a grandparent
dataverse, which is also the case when you won't need the dialog, so
just don't render it.

for compute - adding a facet gives the header a value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JingMa87 @janvanmansum