Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue/22 #28

Merged
merged 6 commits into from
Mar 10, 2021
Merged

Fix Issue/22 #28

merged 6 commits into from
Mar 10, 2021

Conversation

audreyeternal
Copy link
Collaborator

Fix issue #22.

@nwessman nwessman self-requested a review March 10, 2021 20:01
nwessman
nwessman approved these changes Mar 10, 2021
Copy link
Collaborator

@nwessman nwessman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exportAnimationTest() yields fileNotFoundException

@nwessman
Copy link
Collaborator

The faulty test got an error we suspect has something to do with Gson.JsonParser and how it handles intendations and spaces, maybe. The program can export jsons and then import the exported json and still parse it. So the problem seems to be on Gson and not us.

@nwessman nwessman self-requested a review March 10, 2021 22:15
Copy link
Collaborator

@nwessman nwessman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nwessman nwessman merged commit 20574be into issue/321 Mar 10, 2021
@nwessman nwessman deleted the issue/22 branch March 10, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants