Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arrow key shortcuts. #812

Merged
merged 3 commits into from
May 13, 2022
Merged

Add arrow key shortcuts. #812

merged 3 commits into from
May 13, 2022

Conversation

jinh0
Copy link
Collaborator

@jinh0 jinh0 commented May 11, 2022

New Shortcut: Move between bounding boxes by arrow keys

Adds feature requested by @carrieeex in issue #665 to use arrow keys for moving between bounding boxes.

It would be nice if we can use arrow keys (left and right) to switch between different bounding boxes. For example, when users choose "select by BBox", and then click one of the bounding boxes, press the right arrow key would switch to the BBox on the right.

Demo:

Screen.Recording.2022-05-10.at.10.07.06.AM.mov

EDIT:

Arrow keys now move correctly through syllables.

Screen.Recording.2022-05-10.at.11.39.00.AM.mov

@jinh0 jinh0 requested a review from yinanazhou May 11, 2022 20:48
@yinanazhou
Copy link
Member

Hi, I'm getting some no facsimile interface error message in the console.

For example,
image
image

It's the same error message as the one @cadagong is getting. It works well in gh-pages so I think it's related to your changes. Could you two please discuss and fix this?

@yinanazhou yinanazhou merged commit 9f16856 into develop May 13, 2022
@jinh0 jinh0 deleted the arrowkeys-fix branch May 20, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants