Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEI Encoding] Incorrect Version #883

Merged
merged 1 commit into from
May 19, 2023

Conversation

jackyyzhang03
Copy link
Contributor

@jackyyzhang03 jackyyzhang03 commented May 12, 2023

Resolves: (#869)

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

(Describe the changes you've made and the purpose of this PR)

  • Update build_mei_file.py so that clef and accid elements can now be contained inside syllable elements as per 5.0.0-dev
  • Simplify if conditions to improve readability

@sabrina0822 sabrina0822 merged commit eb98584 into develop May 19, 2023
softcat477 added a commit that referenced this pull request May 24, 2023
sabrina0822 added a commit that referenced this pull request May 24, 2023
Fix #909 Update testcase for mei encoding in PR #883
@softcat477 softcat477 deleted the jacky/update-mei-encoding-version branch August 21, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants