Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MEI Encoding] Incorrect Custos Notes #898

Merged
merged 3 commits into from
May 24, 2023
Merged

[MEI Encoding] Incorrect Custos Notes #898

merged 3 commits into from
May 24, 2023

Conversation

jackyyzhang03
Copy link
Contributor

@jackyyzhang03 jackyyzhang03 commented May 18, 2023 •
edited by softcat477
Loading

Resolves: (#888)

  • I passed the docker hub test, and images can be built successfully.
  • I passed the GitHub CI test, so rodan functionalities and jobs work.

(Describe the changes you've made and the purpose of this PR)

  • Override custos pitch information using the pitch of the first neume after a close-enough subsequent clef

@jackyyzhang03 jackyyzhang03 self-assigned this May 18, 2023
@jackyyzhang03 jackyyzhang03 force-pushed the jacky/custos-take-pitch-from-next-neume branch 2 times, most recently from e7b49cf to 91153da Compare May 19, 2023 18:32
@jackyyzhang03 jackyyzhang03 marked this pull request as ready for review May 19, 2023 18:53
@softcat477 softcat477 linked an issue May 24, 2023 that may be closed by this pull request
[MEI Encoding] Incorrect Custos Notes #888
Closed
yinanazhou
yinanazhou approved these changes May 24, 2023
View reviewed changes
rodan-main/code/rodan/jobs/MEI_encoding/build_mei_file.py
@@ -418,6 +418,48 @@ def add_to_syllable(syl_dict, tag, layer, new_element, cur_syllable):
cur_syllable.append(new_element)
add_to_layer(syl_dict, tag, layer, cur_syllable)

def index_of_next_glyph_of_type(all_glyphs, glyph_type, starting_index = 0):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A function name like get_next_index_by_type might be better.

@softcat477 softcat477 mentioned this pull request May 24, 2023
Closed
@softcat477 softcat477 self-requested a review May 24, 2023 17:16
@jackyyzhang03 jackyyzhang03 force-pushed the jacky/custos-take-pitch-from-next-neume branch from 91153da to 1cc60fb Compare May 24, 2023 19:32
@softcat477 softcat477 force-pushed the jacky/custos-take-pitch-from-next-neume branch from 1cc60fb to 07d0d50 Compare May 24, 2023 19:51
@softcat477 softcat477 merged commit b47ca98 into develop May 24, 2023
@softcat477 softcat477 deleted the jacky/custos-take-pitch-from-next-neume branch August 21, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softcat477 softcat477 softcat477 approved these changes

@yinanazhou yinanazhou yinanazhou approved these changes

@sabrina0822 sabrina0822 Awaiting requested review from sabrina0822

Assignees

@jackyyzhang03 jackyyzhang03

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MEI Encoding] Incorrect Custos Notes
3 participants
@jackyyzhang03 @softcat477 @yinanazhou