Recurring payments job sets up new permissions in DynamoDb #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irisfaraway
force-pushed
the
feature/iwtf-4017-recurring-payments-dynamodb
branch
2 times, most recently
from
21fc49d
to
fe4c70c
Compare
irisfaraway
added a commit
that referenced
this pull request
Jun 6, 2024
https://eaflood.atlassian.net/browse/IWTF-4017 This is required for IWTF-4017 as we will need a new function within the Sales API to retrieve data about a permission based on its full reference number. See #1957 for further implementation.
irisfaraway
added a commit
that referenced
this pull request
Jun 6, 2024
https://eaflood.atlassian.net/browse/IWTF-4017 This is required for IWTF-4017 as we will need a new function within the Sales API to prepare data for a recurring payment. The recurring payment job needs to be able to conenct to this new feature so this PR updates the connector. See #1957 for further implementation.
irisfaraway
added a commit
that referenced
this pull request
Jun 6, 2024
https://eaflood.atlassian.net/browse/IWTF-4017 This is required for IWTF-4017 as we will need a new function within the Sales API to retrieve data about a permission based on its full reference number. See #1957 for further implementation.
irisfaraway
added a commit
that referenced
this pull request
Jun 6, 2024
https://eaflood.atlassian.net/browse/IWTF-4017 This is required for IWTF-4017 as we will need a new function within the Sales API to prepare data for a recurring payment. The recurring payment job needs to be able to conenct to this new feature so this PR updates the connector. See #1957 for further implementation.
irisfaraway
force-pushed
the
feature/iwtf-4017-recurring-payments-dynamodb
branch
from
623108a
to
9c0b210
Compare
https://eaflood.atlassian.net/browse/IWTF-4017 When the RP job is run and relevant permissions are found that need to be renewed, we want to create a new permission for the renewal and store it in DynamoDb. This permission should have all the relevant data that needs to be carried over. The new permission won't be moved over to the CRM until payment has successfully been taken. As part of this we need to adapt some of the code that was written for easy renewals.
The refactor revealed that we were only ever assigning the result of getLicenceStartDate when renewedHasExpired was false. So there's no point returning a value if it's true.
irisfaraway
force-pushed
the
feature/iwtf-4017-recurring-payments-dynamodb
branch
from
a749e3b
to
9a205f5
Compare
This may seem like a redundant change but apparently it is what SonarCloud prefers, so...
jaucourt
requested changes
Jun 12, 2024
packages/recurring-payments-job/src/recurring-payments-processor.js
Outdated
Show resolved
Hide resolved
packages/recurring-payments-job/src/recurring-payments-processor.js
Outdated
Show resolved
Hide resolved
| { | ||
| isLicenceForYou: data.isLicenceForYou, | ||
| isRenewal: data.isRenewal, | ||
| issueDate: null, |
There was a problem hiding this comment.
Could you omit this? Or does the issueDate key have to exist in the permission object?
There was a problem hiding this comment.
Required by the permission schema, unfortunately!
packages/recurring-payments-job/src/recurring-payments-processor.js
Outdated
Show resolved
Hide resolved
packages/recurring-payments-job/src/__tests__/recurring-payments-processor.spec.js
Show resolved
Hide resolved
packages/recurring-payments-job/src/__tests__/recurring-payments-processor.spec.js
Show resolved
Hide resolved
packages/sales-api-service/src/services/renewals/renewals.service.js
Outdated
Show resolved
Hide resolved
packages/sales-api-service/src/services/renewals/renewals.service.js
Outdated
Show resolved
Hide resolved
|
jaucourt
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/IWTF-4017
When the RP job is run and relevant permissions are found that need to be renewed, we want to create a new permission for the renewal and store it in DynamoDb. This permission should have all the relevant data that needs to be carried over. The new permission won't be moved over to the CRM until payment has successfully been taken.
As part of this we need to adapt some of the code that was written for easy renewals.