Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recurring payments job sets up new permissions in DynamoDb #1957

Merged
merged 31 commits into from
Jun 17, 2024
Merged

Recurring payments job sets up new permissions in DynamoDb #1957

merged 31 commits into from
Jun 17, 2024

Commits on Jun 11, 2024

  1. Recurring payments job sets up new permissions in DynamoDb 

    https://eaflood.atlassian.net/browse/IWTF-4017

When the RP job is run and relevant permissions are found that need to be renewed, we want to create a new permission for the renewal and store it in DynamoDb. This permission should have all the relevant data that needs to be carried over. The new permission won't be moved over to the CRM until payment has successfully been taken.

As part of this we need to adapt some of the code that was written for easy renewals.
    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    9ac7ff5 View commit details
    Browse the repository at this point in the history

  2. Create renewals-lib for shared functionality

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    d337527 View commit details
    Browse the repository at this point in the history

  3. Rename new lib

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    4cbea1c View commit details
    Browse the repository at this point in the history

  4. Add new lib to main readme

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    c916add View commit details
    Browse the repository at this point in the history

  5. Move new functionality to Sales API instead of lib

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    429fe60 View commit details
    Browse the repository at this point in the history

  6. Add date data processing

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    f666ae8 View commit details
    Browse the repository at this point in the history

  7. Remove redundant param

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    4b960e7 View commit details
    Browse the repository at this point in the history

  8. Process all licensee data

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    6bd887b View commit details
    Browse the repository at this point in the history

  9. Add remaining base permission data and centralise

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    ae1d36b View commit details
    Browse the repository at this point in the history

  10. Add more specific tests

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    7320618 View commit details
    Browse the repository at this point in the history

  11. Remove redundant code 

    The refactor revealed that we were only ever assigning the result of getLicenceStartDate when renewedHasExpired was false. So there's no point returning a value if it's true.
    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    0240ea7 View commit details
    Browse the repository at this point in the history

  12. Add schema for validating renewals route in Sales API

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    3a31a86 View commit details
    Browse the repository at this point in the history

  13. Add renewals route to Sales API

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    721caea View commit details
    Browse the repository at this point in the history

  14. Hopefully fix RCP job package version issues

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    5ac17a7 View commit details
    Browse the repository at this point in the history

  15. Update RCP dependency version after rebase

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    f40fd62 View commit details
    Browse the repository at this point in the history

  16. Pull processed data from Sales API to RP job

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    a0832ea View commit details
    Browse the repository at this point in the history

  17. Include country name in renewal data

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    effefa6 View commit details
    Browse the repository at this point in the history

  18. Include permitId in renewal data

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    73116f8 View commit details
    Browse the repository at this point in the history

  19. Save new transactions to DynamoDb

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    cb164e0 View commit details
    Browse the repository at this point in the history

  20. Update package version after rebase

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    9a205f5 View commit details
    Browse the repository at this point in the history

  21. Add additional testing

    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    376b9e4 View commit details
    Browse the repository at this point in the history

  22. Tweak presentation of key to be dropped 

    This may seem like a redundant change but apparently it is what SonarCloud prefers, so...
    @irisfaraway
    irisfaraway committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    cd9403b View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Remove temp logging, clarify other log

    @irisfaraway
    irisfaraway committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    91739a3 View commit details
    Browse the repository at this point in the history

  2. Remove redundant assignment

    @irisfaraway
    irisfaraway committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    0be3ce2 View commit details
    Browse the repository at this point in the history

  3. Use implicit returns

    @irisfaraway
    irisfaraway committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a9f1878 View commit details
    Browse the repository at this point in the history

  4. Add const for clarification

    @irisfaraway
    irisfaraway committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    532b147 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. More tests for licensee and startDate

    @irisfaraway
    irisfaraway committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    459242e View commit details
    Browse the repository at this point in the history

  2. Test creating 2, 3 or 10 transactions

    @irisfaraway
    irisfaraway committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    2b9530f View commit details
    Browse the repository at this point in the history

  3. Add more tests for metadata

    @irisfaraway
    irisfaraway committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    ac32ff2 View commit details
    Browse the repository at this point in the history

  4. Fix test name

    @irisfaraway
    irisfaraway committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    9dddeaf View commit details
    Browse the repository at this point in the history

  5. Fix package-lock.json

    @irisfaraway
    irisfaraway committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    94cbf82 View commit details
    Browse the repository at this point in the history