Add govuk components #466
Add govuk components #466
Conversation
|
Review apps are failing to build this. Error: This line seems to be causing the problem. If I change it to |
aliuk2012
force-pushed
the
add-govuk-components
branch
from
27eec23
to
5fb0fb2
Compare
There seemed to be only one govuk_link_to which was using a block. I assume the reason it was a block was because it was using html markup and rails would have been escaping it. This can be overcome by using html_safe.
aliuk2012
force-pushed
the
add-govuk-components
branch
from
5fb0fb2
to
59d96de
Compare
This issue was a bug with govuk-components but it has now been fixed in version 0.3.0. |
|
Thanks @aliuk2012 for taking a run at this work. I've taken a cursory look and there's probably a few things that we may want to tweak before we bring this in, but I think it'd be a good improvement overall. However, given where we are in our delivery right now, it's going to be difficult to prioritise picking this PR up in the next few days but I hope we can loop back to it in a couple of weeks. |
|
Closing this as we agreed to break this branch up into smaller PR. |
Context
Changes proposed in this pull request
Adds govuk-component gem - (Demo)
Replaces tag component with govuk-component version
Replaces summary list component with govuk-component version
Replaces breadcrumbs component with govuk-component version
Replaces govuk_link_to helper with govuk-component version
There is plenty more that could be replaced but I'll leave that for another PR, otherwise this is going to be an even larger PR to review.
Guidance to review
Attempt to view different pages in the review app https://ghwt-review-pr-466.herokuapp.com/