This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
Swap out govuk_link_to with govuk-component version #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seemed to be only one govuk_link_to which was using a block. I assume the reason it was a block was because it was using html markup and rails would have been escaping it. This can be overcome by using html_safe.
fofr
reviewed
Sep 21, 2020
| <%= govuk_link_to('', new_responsible_body_internet_mobile_manual_request_path( anchor: 'extra-mobile-data-request-account-holder-name-field') ) do %> | ||
| Change<span class="govuk-visually-hidden"> Account holder name</span> | ||
| <%- end %> | ||
| <%= govuk_link_to('Change<span class="govuk-visually-hidden"> Account holder name</span>'.html_safe, |
There was a problem hiding this comment.
(We should push the block logic upstream to govuk-components, so that govuk_link_to continues to act like the native link_to does.)
There was a problem hiding this comment.
Good point, I'll take that up with govuk-components but I don't see that being a blocker for us to get this merged.
|
For reference, switching to this implementation: |
|
I've raised the issue of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes proposed in this pull request
There is only one major difference between govuk-component helper method implementation and the one in the service. The difference is that govuk-component helper method does not support passing in a block. I don't see this as a blocker as I could only see one instance where a block was used and I assume the reason it was a block was because it was using html markup and rails would have been escaping it. This could have been overcome by using html_safe.
Guidance to review