This repository has been archived by the owner on Mar 22, 2021. It is now read-only.
[serial] Improve current best case cmd() method to old feature set
#69
Labels
Comments
|
@sledz Please review if that is acceptable for now. |
erikbgithub
added a commit
that referenced
this issue
Jul 9, 2013
According to the research in Issue #60 (#60), the simplest implementation for best case scenarios is only 2 lines. This commit implements those 2 lines instead of the complex behaviour before. Issue #69 (#69) shall improve or replace that method with a more practical implementation, if that is not already finished with Issue #61 (#61). See Github Issue #60 for details. Signed-off-by: Erik Bernoth <erik.bernoth@gmail.com> Acked-by: Steffen Sledz <sledz@dresearch-fe.de> Acked-by: Eik Binschek <binschek@dresearch-fe.de>
erikbgithub
added a commit
that referenced
this issue
Jul 9, 2013
According to the research in Issue #60 (#60), the simplest implementation for best case scenarios is only 2 lines. This commit implements those 2 lines instead of the complex behaviour before. Issue #69 (#69) shall improve or replace that method with a more practical implementation, if that is not already finished with Issue #61 (#61). See Github Issue #60 for details. Signed-off-by: Erik Bernoth <erik.bernoth@gmail.com> Acked-by: Steffen Sledz <sledz@dresearch-fe.de> Acked-by: Eik Binschek <binschek@dresearch-fe.de>
|
Yes, it's acceptable. |
|
I guess I just forgot to close this one, back in the day |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Situation
The current implementation of
cmd()results from the experimental Issue #60. There are some flaws (#61) that make it less useful for practical application though.Task
Summarize the features and bug fixes included in the old
SerialConn.cmd(). Enable a behavior that corresponds to the feature set of that oldcmd()method without the known bugs.Notes
none yet
The text was updated successfully, but these errors were encountered: