getplants fixes #2731
Merged
getplants fixes #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 27, 2023 14:44
Now `toUpper` is called on user input when it's added to `plantNames` to ensure it matches the ID fields which are all in upper-case.
The `ripe` call was returning false on tree tiles, resulting in an inability to designate trees for chopping with `getplants`. This change adds a check to see if the tile is a tree or not and if it is, then the ripe check is ignored.
myk002
reviewed
Jan 27, 2023
I don't believe so, no big changes have been made to it's behaviour.
Updated the changelog & merged develop :) |
myk002
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, just some small first-timer fixing issues I found for the getplants plugin.
Fixes #1805
ID parameters are now added to
plantNameswith atoUppercasecall, so case doesn't matter for input.Fixes #2043
The
designatecall was returning false for all trees because theripecheck was failing.My guess is that the trees either have a different lifetime or aren't ripe but it doesn't matter because they can still be chopped. I'm wasn't sure what the best way to fix this one was, so I added an
istreecheck for the tile and now the check passes ifistree || isripe.I did some brief testing and it seems good.